Enhance orchestration template parameter type support #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was accidently left blank when moved from manageiq repo
bzwei
force-pushed
the
ot_parameters
branch
3 times, most recently
from
bcd73e2 to
bce829b
Compare
|
@bzwei unrecognized command 'bug', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
@miq-bot add_label bug |
|
@miq-bot add_label wip |
miq-bot
changed the title
Better support non-string parameter types including comma-delimited-list, number, boolean https://bugzilla.redhat.com/show_bug.cgi?id=1489908
|
@miq-bot remove_label wip |
|
Checked commits bzwei/manageiq-providers-openstack@0c1cdc4~...618d9d5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
miq-bot
changed the title
Ladas
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better support non-string parameter types including comma-delimited-list, number, boolean
https://bugzilla.redhat.com/show_bug.cgi?id=1489908
depends on
ManageIQ/manageiq#16047Update:
The work now also include better support Cloudformation template. So it is able to accept both HOT and Cloudformation templates in either JSON or YAML format.
The last commit fixed an error in spec test that references to a factory that has been removed from manageiq repo.